[Minor] Catch exception from snapshot uploading #48185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedyu
changed the title
|
@HeartSaVioR |
tedyu
changed the title
|
@anishshri-db |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When
enableChangelogCheckpointingis true, we calluploadSnapshot. If there is exception coming out of this call, currently changelog files are not written.This PR catches the potential exception from
uploadSnapshot, write the changelog files and throw the exception.Why are the changes needed?
This is to ensure that changelog files are always written.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test suite.
Was this patch authored or co-authored using generative AI tooling?
No.